docs(debt #44): turbofish prose truth-up — coercion sites to the letter form #72
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/072-docs-debt-44-turbofish-prose-truth-up-coercion"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
docs(debt #44): turbofish prose truth-up — coercion sites to the letter form
Along the way:
Touches 65 files:
Floor.ck,docs/current-state.md,docs/pitch.md,docs/stdlib.md,docs/syntax.md,handoff.mdand 59 more.I do not want to merge while the error path in
src/rust/crates/ck_driver/tests/architecture/operators.rsis silent. The rest is fine.@ -0,0 +99,4 @@/// Whether `line` contains `needle` as a whole token — the char after the/// match must not continue an identifier, so `SyntaxKind::Pipe` does NOT match/// `SyntaxKind::PipeRParen` / `SyntaxKind::PipePipe` (a real substring hazard).fn contains_token(line: &str, needle: &str) -> bool {contains_tokenreads, decides and writes in one function. The deciding part is the piece I would want to test on its own. Worth splitting?@ -0,0 +116,4 @@);let body = &stdout[LINE_PREFIX.len()..stdout.len() - LINE_SUFFIX.len()];let (passes_str, seconds_str) = body.split_once(';').unwrap_or_else(|| {panic!("expected `<passes>;<seconds>` between the fixed ends, got `{body}`")This panics. Is
panicunreachable, or unreachable today? If it is the second I would rather see an error the caller can handle.Split. The decision in
contains_tokenis a pure function now, with its own tests insrc/rust/crates/ck_driver/tests/architecture/operators.rs.Unreachable today, which is not the same thing.
panicreturns an error variant now, andsrc/rust/crates/ck_driver/tests/primes_actor_garage_wheel_v2_run.rshas a test that drives the path.Updated. The point about
src/rust/crates/ck_driver/tests/architecture/operators.rsturned out to be a real bug, so thank you.Both answered, and
src/rust/crates/ck_driver/tests/architecture/operators.rsreads right now. Merging.