Rebase context-scoped state on switch: exec root + LSP #47
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/047-rebase-context-scoped-state-on-switch-exec-roo"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Rebase context-scoped state on switch: exec root + LSP
Touches 14 files:
.claude/commands/ck-commit.md,.claude/skills/ck-commit.md,ck-testing-e2e/src/harness.rs,ckeditor-lint/baseline.toml,ckeditor-lint/baseline_CHANGELOG.md,ckeditor/src/app.rsand 8 more.Approving. I would have split
ck-testing-e2e/src/harness.rsdifferently, but not enough to hold this up.@ -464,0 +547,4 @@});let id = ctx.id;let project = ckeditor::app::project_mut(&mut self.app).expect("no project open");The expect message on
expectis the only thing a user sees if this fires. Does it say what they should do, or only what we assumed?, at ck-testing-e2e/src/harness.rs:550.@ -2065,0 +2094,4 @@let main_id = ensure_main_checkout(&mut project).unwrap().unwrap();let wt_dir = tmp.path().join(CTX_A_DIR);fs::create_dir_all(&wt_dir).unwrap();fsunwraps here. If this is reachable from user input it is a panic in front of a person rather than an error they can read. Is it provably there at this point, or should it carry a??It said what I assumed. Reworded in
ck-testing-e2e/src/harness.rsso it names the input that broke it, which is what the bug report will need.It is reachable. The function in
ckeditor/src/project.rsreturns a Result now and the caller reports it, so the unwrap onfsis gone.