northgale/ckeditor
Watch
12
0
Fork
You've already forked ckeditor
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Scaffold ck-notes crate with sealing preamble and design doc #49

Manually merged
hkowalski merged 1 commit from feat/049-scaffold-ck-notes-crate-with-sealing-preamble into master 2026-06-25 11:58:41 +02:00
Conversation 3 Commits 1 Files changed 6 +442 -1
hkowalski commented 2026-06-24 13:17:22 +02:00
Owner
Copy link

Scaffold ck-notes crate with sealing preamble and design doc

Touches 6 files: Cargo.lock, Cargo.toml, ck-notes/Cargo.toml, ck-notes/README.md, ck-notes/src/lib.rs, ckeditor-notes.md.

Scaffold ck-notes crate with sealing preamble and design doc Touches 6 files: `Cargo.lock`, `Cargo.toml`, `ck-notes/Cargo.toml`, `ck-notes/README.md`, `ck-notes/src/lib.rs`, `ckeditor-notes.md`.
cmwangi approved these changes 2026-06-25 07:00:00 +02:00
cmwangi left a comment
Copy link

Yes. The commit messages carried me through all 6 files, which is not always true.

Yes. The commit messages carried me through all 6 files, which is not always true.
ck-notes/README.md
@ -0,0 +49,4 @@
| Gate | Target | Actual |
|---|---|---|
| Line coverage (`scripts/test.sh ck-notes --coverage`) | 100% | _scaffold — no code yet_ |
| Mutation kill rate (`scripts/test.sh ck-notes --mutants`) | ≥ 95% | _scaffold — no code yet_ |
cmwangi commented 2026-06-25 07:00:00 +02:00
Owner
Copy link

Where does the number beside rate come from? It reads as measured rather than chosen, and nothing on the line says which.

Where does the number beside `rate` come from? It reads as measured rather than chosen, and nothing on the line says which.
ck-notes/src/lib.rs
@ -0,0 +50,4 @@
//! commit is a skeleton — the preamble names the contract; subsequent
//! commits land the code that earns it.
#![deny(missing_docs)]
cmwangi commented 2026-06-25 07:00:00 +02:00
Owner
Copy link

I had to read deny twice. Nothing wrong with it, but one line of comment would save the next person the second read.

I had to read `deny` twice. Nothing wrong with it, but one line of comment would save the next person the second read.
hkowalski commented 2026-06-25 08:00:00 +02:00
Author
Owner
Copy link

Comment added on deny in ck-notes/src/lib.rs. It was obvious when I wrote it and it will not be in a month.

Comment added on `deny` in `ck-notes/src/lib.rs`. It was obvious when I wrote it and it will not be in a month.
hkowalski commented 2026-06-25 08:00:00 +02:00
Author
Owner
Copy link

Measured. It is a named constant in ck-notes/README.md now, with a line saying how.

Measured. It is a named constant in `ck-notes/README.md` now, with a line saying how.
Empty crate registered in the workspace with #![deny(missing_docs)] on
day one and a README that mirrors the lib preamble so the contract is
discoverable cold. ckeditor-notes.md is the upstream of the work that
follows on this branch: it fixes the data model (Note + NoteId UUID +
NoteStatus enum + updated_at), the persistence format (one markdown
file per note with TOML frontmatter under .ckeditor/notes/, all I/O via
ck-files), the migration story from the legacy notes.json blob, the UI
overhaul scope (large markdown editor, side-by-side preview, status
dropdown, search bar), the sealing plan (100% line + ≥95% mutation kill
from tests/ alone), and the 5-commit sequence the rest of this branch
will land. No code moved yet — this is the agreement before the lift.
hkowalski manually merged commit 53beb80996 into master 2026-06-25 11:58:41 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
cmwangi
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
northgale/ckeditor!49
No description provided.