Feat(types): land Slice TY2 — bidirectional core #14
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/014-feat-types-land-slice-ty2-bidirectional-core"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Feat(types): land Slice TY2 — bidirectional core
Along the way:
Touches 25 files:
docs/impl/slices.md,docs/impl/type-system/README.md,docs/impl/type-system/TY2-bidirectional-core.md,docs/impl/type-system/TY6-construction-and-projection.md,src/rust/Cargo.lock,src/rust/crates/ck_cktest/Cargo.tomland 19 more.Reads well. One question on
src/rust/crates/ck_types/src/lib.rs, nothing blocking.@ -0,0 +54,4 @@/// The type recorded for a local binder, if any.#[must_use]pub fn type_of_local(&self, id: LocalId) -> Option<&Ty> {type_of_localis public. Does anything outside the crate call it, or is it pub because that was easier? Every public item is a promise.@ -393,0 +581,4 @@}#[test]fn display_renders_each_variant_in_its_keyword_form() {display_renders_each_variant_in_its_keyword_formreads, decides and writes in one function. The deciding part is the piece I would want to test on its own. Worth splitting?Split. The decision in
display_renders_each_variant_in_its_keyword_formis a pure function now, with its own tests insrc/rust/crates/ck_types/src/lib.rs.Nothing outside calls
type_of_local. It is pub(crate) insrc/rust/crates/ck_types/src/check.rsnow.