The capability matrix's entry: axis (ruling #26) #158
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/158-the-capability-matrix-s-entry-axis-ruling-26"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The capability matrix's entry: axis (ruling #26)
Along the way:
Touches 7 files:
src/rust/crates/ck_cktest/src/capability.rs,src/rust/crates/ck_cktest/src/lib.rs,src/rust/crates/ck_driver/tests/capability.rs,tests/README.md,tests/capability/README.md,tests/capability/a_test_body_that_does_not_lower_is_inert_on_the_run_path.cktestand 1 more.A clear improvement. The change in
src/rust/crates/ck_cktest/src/capability.rsis the part I would have argued for.@ -434,0 +645,4 @@let test = parse(src).unwrap();let blessed = render_blessed(&test, "capability");assert!(blessed.contains("# capability\n\nentry: test\nlower: WithMutTarget\n"));assert_eq!(parse(&blessed).unwrap().capability, test.capability);parseunwraps here. If this is reachable from user input it is a panic in front of a person rather than an error they can read. Is it provably there at this point, or should it carry a??It is reachable. The function in
src/rust/crates/ck_cktest/src/capability.rsreturns a Result now and the caller reports it, so the unwrap onparseis gone.Looked through
src/rust/crates/ck_cktest/src/capability.rsas well. Fine by me.