The effect graph fills ck_effects (ruling #30) #160
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/160-the-effect-graph-fills-ck-effects-ruling-30"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The effect graph fills ck_effects (ruling #30)
Along the way:
Touches 2 files:
src/rust/crates/ck_effects/src/lib.rs,src/rust/crates/ck_effects/src/tests.rs.Good. Small enough to read in one sitting, and
src/rust/crates/ck_effects/src/tests.rsis easier to follow than it was.@ -5,0 +225,4 @@/// forbids to declare `e` while 3b must still thread a handle through/// them, which is the whole reason this crate exists.#[must_use]pub fn carries_only(&self, f: FnId, e: EffectId) -> bool {carries_onlyis public. Does anything outside the crate call it, or is it pub because that was easier? Every public item is a promise.@ -0,0 +100,4 @@}#[test]fn mutual_recursion_settles_instead_of_spinning() {mutual_recursion_settles_instead_of_spinningreads, decides and writes in one function. The deciding part is the piece I would want to test on its own. Worth splitting?Split. The decision in
mutual_recursion_settles_instead_of_spinningis a pure function now, with its own tests insrc/rust/crates/ck_effects/src/tests.rs.Nothing outside calls
carries_only. It is pub(crate) insrc/rust/crates/ck_effects/src/lib.rsnow.Second read on
src/rust/crates/ck_effects/src/tests.rs. Nothing to add.