Call_indirect carries its declared signature (ruling #32) #164
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/164-call-indirect-carries-its-declared-signature-r"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Call_indirect carries its declared signature (ruling #32)
Along the way:
Touches 5 files:
src/rust/crates/ck_codegen/src/call.rs,src/rust/crates/ck_codegen/src/indirect.rs,src/rust/crates/ck_lower/src/floor_ir.rs,src/rust/crates/ck_lower/src/floor_ir/indirect_sig.rs,src/rust/crates/ck_lower/src/floor_ir/lc8_tests.rs.Yes. The commit messages carried me through all 5 files, which is not always true.
@ -0,0 +21,4 @@/// This is the shape `CallIndirect` carries and the reason the widening is/// producer-side only.#[test]fn a_wider_producer_declares_its_own_signature() {a_wider_producer_declares_its_own_signaturereads, decides and writes in one function. The deciding part is the piece I would want to test on its own. Worth splitting?Split. The decision in
a_wider_producer_declares_its_own_signatureis a pure function now, with its own tests insrc/rust/crates/ck_lower/src/floor_ir/lc8_tests.rs.Looked through
src/rust/crates/ck_lower/src/floor_ir/lc8_tests.rsas well. Fine by me.