northgale/cklang-bootstrap
Watch
12
0
Fork
You've already forked cklang-bootstrap
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

docs(plan_determinism): U2 wording follows #13's staging — refusal at CHECK entry points; build-entry becomes true at 'then hard' #174

Manually merged
mdoorn merged 3 commits from feat/174-docs-plan-determinism-u2-wording-follows-13-s into master 2026-07-27 08:30:00 +02:00
Conversation 5 Commits 3 Files changed 3 +72 -57
lnguyen commented 2026-07-17 16:08:27 +02:00
Owner
Copy link

docs(plan_determinism): U2 wording follows #13's staging — refusal at CHECK entry points; build-entry becomes true at 'then hard'

Along the way:

  • progress: the bounded-note unit test follows #40's honest rendering (fully-bounded -> bounded-where-composed)
  • docs(handoff): night position — DETERMINISM LANDED, gate green at tip; testing resumes at 3b commit 2

Touches 3 files: handoff.md, plan_determinism.md, src/rust/crates/ck_driver/src/progress.rs.

docs(plan_determinism): U2 wording follows #13's staging — refusal at CHECK entry points; build-entry becomes true at 'then hard' Along the way: - progress: the bounded-note unit test follows #40's honest rendering (fully-bounded -> bounded-where-composed) - docs(handoff): night position — DETERMINISM LANDED, gate green at tip; testing resumes at 3b commit 2 Touches 3 files: `handoff.md`, `plan_determinism.md`, `src/rust/crates/ck_driver/src/progress.rs`.
praghunathan requested changes 2026-07-21 06:30:00 +02:00
Dismissed
praghunathan left a comment
Copy link

I do not want to merge while the error path in src/rust/crates/ck_driver/src/progress.rs is silent. The rest is fine.

I do not want to merge while the error path in `src/rust/crates/ck_driver/src/progress.rs` is silent. The rest is fine.
handoff.md
@ -40,0 +35,4 @@
decoy sup "0::usize". THEN 3d: Assert actor (check/true/equal; `true` =
one line in name_slot.rs is_contextual_name_kw; Test::run KILLS the
instance after reporting per #39) · CONDEMNED_COMPOUNDS 4 → 0 · #29
re-check (likely moot).
praghunathan commented 2026-07-21 06:30:00 +02:00
Owner
Copy link

I had to read check twice. Nothing wrong with it, but one line of comment would save the next person the second read.

I had to read `check` twice. Nothing wrong with it, but one line of comment would save the next person the second read.
src/rust/crates/ck_driver/src/progress.rs
@ -465,3 +465,2 @@
#[test]
fn bounded_actor_prints_calculated_and_measured_with_fully_bounded_note() {
// The helloWorld shape: fully bounded, zero bytes, measured high-water 0.
fn bounded_actor_prints_calculated_and_measured_with_composed_note() {
praghunathan commented 2026-07-21 06:30:00 +02:00
Owner
Copy link

bounded_actor_prints_calculated_and_measured_with_composed_note reads, decides and writes in one function. The deciding part is the piece I would want to test on its own. Worth splitting?

`bounded_actor_prints_calculated_and_measured_with_composed_note` reads, decides and writes in one function. The deciding part is the piece I would want to test on its own. Worth splitting?
lnguyen commented 2026-07-23 03:30:00 +02:00
Author
Owner
Copy link

Split. The decision in bounded_actor_prints_calculated_and_measured_with_composed_note is a pure function now, with its own tests in src/rust/crates/ck_driver/src/progress.rs.

Split. The decision in `bounded_actor_prints_calculated_and_measured_with_composed_note` is a pure function now, with its own tests in `src/rust/crates/ck_driver/src/progress.rs`.
lnguyen commented 2026-07-23 11:33:23 +02:00
Author
Owner
Copy link

Comment added on check in handoff.md. It was obvious when I wrote it and it will not be in a month.

Comment added on `check` in `handoff.md`. It was obvious when I wrote it and it will not be in a month.
lnguyen commented 2026-07-25 03:30:00 +02:00
Author
Owner
Copy link

Pushed a fix for both. The second pass on src/rust/crates/ck_driver/src/progress.rs is much smaller than the first.

Pushed a fix for both. The second pass on `src/rust/crates/ck_driver/src/progress.rs` is much smaller than the first.
praghunathan approved these changes 2026-07-26 09:15:50 +02:00
praghunathan left a comment
Copy link

Good. The second pass on src/rust/crates/ck_driver/src/progress.rs is what I hoped for.

Good. The second pass on `src/rust/crates/ck_driver/src/progress.rs` is what I hoped for.
mdoorn manually merged commit 8aefde9c74 into master 2026-07-27 08:30:00 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
praghunathan
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
northgale/cklang-bootstrap!174
No description provided.