Numbers you can read, and the client stops drawing its own #48
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/048-numbers-you-can-read-and-the-client-stops-draw"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Numbers you can read, and the client stops drawing its own
Along the way:
Touches 30 files:
docs/CHANGELOG.md,docs/README.md,scripts/harness/sections/16-options-window.lua,scripts/harness/sections/33-anchors.lua,scripts/harness/sections/51-placing.lua,scripts/harness/sections/52-character.luaand 24 more.The client's own numbers going away is what makes ours readable; two sets of damage text over one mob is worse than either. Three notes.
@ -283,0 +289,4 @@check(row and row["RightButton"] and row["MiddleButton"],"the gear row keeps the camera's buttons, so a right drag on a row does not turn the camera")check(head.button:GetWidth() < head:GetWidth(),("the secure button is %s wide on a row of %s, so the action is the whole row again")The check is that the secure button is narrower than the row, and the message says the action is the whole row again. Those are opposite statements; one of them is worded backwards.
@ -555,3 +645,2 @@local function Portrait(parent)local panel = UI.Box(parent, C.sunken, C.edge)local level = (panel:GetFrameLevel() or 0) + 5local panel = CreateFrame("Frame", nil, parent)A plain frame wrapping the model, so the model can be absent without the layout changing. That is the shape I would want on every client call that might not be there.
@ -0,0 +170,4 @@end-- How many of the four are down, for the harness.function Blizzard.Quiet()A count of how many of the four are down, for the harness. Four is written twice, here and in TAKEN. Read the length.
#TAKEN, and the loop below it already did.PlayerModel being a frame type rather than a template is what makes it cheap. Both calls on it are probed.
The message was written for the failure and reads as the assertion. Reworded to say what went wrong rather than what should be true.