northgale/warriorkit
Watch
12
0
Fork
You've already forked warriorkit
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Plan: Nine */Blizzard.lua files, one contract, written down nowhere, and 2 more #58

Manually merged
mdoorn merged 3 commits from feat/058-plan-nine-blizzard-lua-files-one-contract-writ into master 2026-08-17 15:41:19 +02:00
Conversation 3 Commits 3 Files changed 7 +73 -4
praghunathan commented 2026-08-14 10:51:39 +02:00
Owner
Copy link

plan: add 01M1XJZTMYRYN6A1THBPY15VSD-nine-blizzard-lua-files-one-contract-written-dow

Along the way:

  • plan: add 01M1XJZTYTM8VZ58PYTW463913-taking-a-key-off-the-client-written-eight-times
  • plan: add 01M1XJZV8CGSQ7VJHSTTCE825X-a-window-has-no-lifecycle-so-twelve-files-invent

Touches 3 files: plan/tickets/01M1XJZTMYRYN6A1THBPY15VSD-nine-blizzard-lua-files-one-contract-written-dow/ticket.md, plan/tickets/01M1XJZTYTM8VZ58PYTW463913-taking-a-key-off-the-client-written-eight-times/ticket.md, plan/tickets/01M1XJZV8CGSQ7VJHSTTCE825X-a-window-has-no-lifecycle-so-twelve-files-invent/ticket.md.

plan: add 01M1XJZTMYRYN6A1THBPY15VSD-nine-blizzard-lua-files-one-contract-written-dow Along the way: - plan: add 01M1XJZTYTM8VZ58PYTW463913-taking-a-key-off-the-client-written-eight-times - plan: add 01M1XJZV8CGSQ7VJHSTTCE825X-a-window-has-no-lifecycle-so-twelve-files-invent Touches 3 files: `plan/tickets/01M1XJZTMYRYN6A1THBPY15VSD-nine-blizzard-lua-files-one-contract-written-dow/ticket.md`, `plan/tickets/01M1XJZTYTM8VZ58PYTW463913-taking-a-key-off-the-client-written-eight-times/ticket.md`, `plan/tickets/01M1XJZV8CGSQ7VJHSTTCE825X-a-window-has-no-lifecycle-so-twelve-files-invent/ticket.md`.
mdoorn approved these changes 2026-08-15 13:45:02 +02:00
mdoorn left a comment
Copy link

One contract written down for nine files that already agreed by accident. That is the cheapest kind of architecture work there is.

One contract written down for nine files that already agreed by accident. That is the cheapest kind of architecture work there is.
plan/tickets/01M1XJZTYTM8VZ58PYTW463913-taking-a-key-off-the-client-written-eight-times/ticket.md
@ -0,0 +8,4 @@
labels: [item-26]
---
`SetOverrideBindingClick` onto a secure button, `ClearOverrideBindings`
mdoorn commented 2026-08-15 13:45:02 +02:00
Owner
Copy link

Eight sites listed with file and line. Add what each one does differently from the other seven, because that is the list that decides whether this is one function or two.

Eight sites listed with file and line. Add what each one does differently from the other seven, because that is the list that decides whether this is one function or two.
praghunathan commented 2026-08-16 06:30:00 +02:00
Author
Owner
Copy link

Added. Six are identical, one keeps the displaced binding and one does not restore at all, and the last is a bug.

Added. Six are identical, one keeps the displaced binding and one does not restore at all, and the last is a bug.
atanabe approved these changes 2026-08-17 02:00:00 +02:00
atanabe left a comment
Copy link

No objection. Eight copies of a four-step dance is exactly the shape that drifts.

No objection. Eight copies of a four-step dance is exactly the shape that drifts.
mdoorn manually merged commit 1b45f9a6e2 into master 2026-08-17 15:41:19 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
mdoorn
atanabe
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
northgale/warriorkit!58
No description provided.