Plan: The spell row on the options page, twice, and 6 more #59
atanabe
sokonkwo
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/059-plan-the-spell-row-on-the-options-page-twice-a"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
plan: add 01M1XJZVHZ4XREST40SGZCD8N8-the-spell-row-on-the-options-page-twice
Along the way:
Touches 7 files:
plan/tickets/01M1XJZVHZ4XREST40SGZCD8N8-the-spell-row-on-the-options-page-twice/ticket.md,plan/tickets/01M1XJZVVJYCKQKGS0DBE13KN7-bags-grid-lua-and-merchant-grid-lua-are-one-grid/ticket.md,plan/tickets/01M1XJZW5CFY7JB9WKRNJC94H0-the-class-files/ticket.md,plan/tickets/01M1XJZWF6S2HNSB0R4J2WJB2A-the-stance-row-and-the-second-reader/ticket.md,plan/tickets/01M1XJZWS8MSHT2Q41R1HDZ5NV-what-a-fifth-class-file-costs-the-gate-before-th/ticket.md,plan/tickets/01M1XJZX2T7CTA69DR84NR59XR-druid-forms-and-the-first-plan-a-spec-overrides/ticket.mdand 1 more.Good set of tickets. Three things before this goes in.
@ -0,0 +17,4 @@A stance fills three of the five reader values, and`src/Standing/Row.lua:261` already reads the other two as `expires[index] or0` and `span[index] or 0`, so `Row.lua` does not change.The claim that Row.lua does not change is the load-bearing one here. Two client calls are named as missing from the harness and neither is listed as work.
@ -0,0 +10,4 @@`scripts/check.sh:1354` reads the class tokens off `Class/*.lua` and runsthe harness once per shape: thirteen runs today, twenty-eight at nineclasses, and the harness is the slowest thing in `check.sh`. Measure one runThirteen runs today and twenty eight at nine classes, and the harness is already the slow half of check.sh. Say what the target is: if twenty eight runs is fine, this ticket is a measurement and not a problem.
@ -0,0 +5,4 @@status: todotitle: "\"Druid: forms, and the first plan a spec overrides.\""parent: 01KH3Y2AV8WE7A7S9TPV22V41Tlabels: [item-55]Labelled item-55 and its parent is the class block, but the body is about a spec overriding a plan, which is a mechanism nothing else has yet. That is a bigger ticket than a class file.
Target written in: one run under four seconds, measured before item 56 and again after.
Split out and unparented. It is the first plan a spec overrides and it should not be hiding under a class file.
Both calls are now work in the ticket, with the file they go in.
Read the reader contract. Three slots filled by a stance and two read as nil-or-zero is a shape the other four classes can take without touching Row.lua.
Clearer. The druid one being its own thing is the right call.
All three in. Thanks for reading it closely, this is the first plan I have written on my own.